Merge branch 'main' into CFE-80-dependency-handling-improvements

Nosto · Dec 12, 2023 · ec39197 · ec39197
2 parents 0e4b470 + 795f652
commit ec39197
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/examples/liquid/autocomplete.liquid b/examples/liquid/autocomplete.liquid
@@ -13,7 +13,7 @@
         <div class="ns-autocomplete-history-item" data-ns-hit="{{ hit | json | escape }}">
           {{ hit.item }}
           <a
-            href="javascript:void(0)"
+            href="javascript:;"
             class="ns-autocomplete-history-item-remove"
             data-ns-remove-history="{{hit.item}}">
             &#x2715;
@@ -54,7 +54,7 @@
         {% for hit in response.products.hits %}
           <a
             class="ns-autocomplete-product"
-            {% comment %} href="{{ hit.url }}" {% endcomment %}
+            href="{{ hit.url }}"
             data-ns-hit="{{ hit | json | escape }}">
             <img
               class="ns-autocomplete-product-image"

diff --git a/examples/mustache/autocomplete.mustache b/examples/mustache/autocomplete.mustache
@@ -64,7 +64,7 @@
       {{#history}}
         <div class="ns-autocomplete-history-item" data-ns-hit="{{toJson}}">
           {{item}}
-          <a href="javascript:void(0)" class="ns-autocomplete-history-item-remove" data-ns-remove-history="{{item}}">
+          <a href="javascript:;" class="ns-autocomplete-history-item-remove" data-ns-remove-history="{{item}}">
             &#x2715;
           </a>
         </div>

diff --git a/spec/components/Autocomplete.tsx b/spec/components/Autocomplete.tsx
@@ -65,7 +65,7 @@ function History({ history }: { history: AutocompleteProps["history"] }) {
                         >
                             {hit.item}
                             <a
-                                href="javascript:void(0)"
+                                href="javascript:;"
                                 className="ns-autocomplete-history-item-remove"
                                 data-ns-remove-history={hit.item}
                             >
@@ -124,7 +124,7 @@ function Products({ products }: { products: SearchProduct[] }) {
                 return (
                     <a
                         className="ns-autocomplete-product"
-                        href="javascript:void(0)"
+                        href="javascript:;"
                         key={hit.productId}
                         data-ns-hit={JSON.stringify(hit)}
                         data-testid="product"