Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated some outdated links #5894

Merged
merged 4 commits into from
Nov 22, 2024
Merged

updated some outdated links #5894

merged 4 commits into from
Nov 22, 2024

Conversation

pucedoteth
Copy link
Contributor

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c54eeca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 3:51pm

alcuadrado
alcuadrado reviewed Oct 30, 2024
View reviewed changes
packages/hardhat-core/README.md
@@ -34,7 +34,7 @@ On [Hardhat's website](https://hardhat.org) you will find:

Contributions are always welcome! Feel free to open any issue or send a pull request.

Go to [CONTRIBUTING.md](./CONTRIBUTING.md) to learn about how to set up Hardhat's development environment.
Go to [CONTRIBUTING.md](https://github.com/NomicFoundation/hardhat/blob/main/CONTRIBUTING.md) to learn about how to set up Hardhat's development environment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one makes more sense. The relative path only works with the symlink in the root of the repo, but not in -core

@kanej kanej added the no changeset needed This PR doesn't require a changeset label Nov 22, 2024
@kanej kanej merged commit 74e8558 into NomicFoundation:main Nov 22, 2024
105 checks passed
@gitpoap-bot gitpoap-bot
Copy link

gitpoap-bot bot commented Nov 22, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Hardhat Contributor:

GitPOAP: 2024 Hardhat Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcuadrado alcuadrado alcuadrado left review comments

@kanej kanej kanej approved these changes

Assignees

@kanej kanej

Labels
no changeset needed This PR doesn't require a changeset status:triaging
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pucedoteth @kanej @alcuadrado