Fix compilation error with latest @types/node #4701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the
SolidityCallSite
class to properly implement the latest version ofNodeJS.CallSite
.Notice that there are three different changes here:
getScriptNameOrSourceURL
. This function wasn't even present in the type definition of@types/node@16
so I'm not sure why it was there. Maybe it was removed and re-added with a different return type? Anyway, I think we can assume no one was using it.getScriptHash
,getEnclosingColumnNumber
andgetEnclosingLineNumber
). If some consumer was calling those methods, then that would've resulted in an error, so we can assume that they were not being used. (You could argue that maybe someone was checking if they existed, but that's a long shot, especially for such an internal object.).toString
. The default result for a class that doesn't implement it is[object Object]
, so I think this is also safe enough.