Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error with latest @types/node #4701

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

fvictorio
Copy link
Member

Adapt the SolidityCallSite class to properly implement the latest version of NodeJS.CallSite.

Notice that there are three different changes here:

  • A change in the return value of getScriptNameOrSourceURL. This function wasn't even present in the type definition of @types/node@16 so I'm not sure why it was there. Maybe it was removed and re-added with a different return type? Anyway, I think we can assume no one was using it.
  • New methods (getScriptHash, getEnclosingColumnNumber and getEnclosingLineNumber). If some consumer was calling those methods, then that would've resulted in an error, so we can assume that they were not being used. (You could argue that maybe someone was checking if they existed, but that's a long shot, especially for such an internal object.)
  • An implementation of .toString. The default result for a class that doesn't implement it is [object Object], so I think this is also safe enough.

Copy link

changeset-bot bot commented Dec 19, 2023

⚠️ No Changeset found

Latest commit: 7de7b68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview Dec 19, 2023 9:04am

@fvictorio fvictorio added the no changeset needed This PR doesn't require a changeset label Dec 19, 2023
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Dec 19, 2023
@fvictorio fvictorio merged commit 31dfa5d into main Dec 26, 2023
91 checks passed
@fvictorio fvictorio deleted the fix-types-node-workflow branch December 26, 2023 11:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants