Expand org owner authority #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to be able to remove the security and systemd team's explicit Nixpkgs write access, which seems to be a historical artifact from needing to have write access to be requested for reviews with CODEOWNERS. The current authority doesn't allow for that, so this PR is expanding it to include that and similar changes.
|
Not a fan of having to list everything explicitly, I'll make another PR. |
winterqt
approved these changes
Jan 22, 2025
| - Performing maintenance. | ||
| - Giving commit access to trusted people that offer maintenance. | ||
| - Archiving if appropriate. | ||
| - Changes to permissions of teams and people |
There was a problem hiding this comment.
If we want this to be non-controversial, perhaps this should be worded as something like "with the team's approval?" Unless that's implied.
|
I opened #61 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to remove the security and systemd team's explicit Nixpkgs write access, which seems to be a historical artifact from needing to have write access to be requested for reviews with CODEOWNERS.
The current authority doesn't allow for that, so this PR is expanding it to include that and similar changes. Notably the expansion is conditioned under non-controversial changes, and needing approval from two org owners.