Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twister: 0.9.34 -> 2019-08-19 #68784

Merged
merged 1 commit into from
Sep 14, 2019
Merged

twister: 0.9.34 -> 2019-08-19 #68784

merged 1 commit into from
Sep 14, 2019

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Sep 14, 2019 •
edited
Loading

Motivation for this change

Wouldn't build with OpenSSL 1.1.x anymore. The new revision makes it work

Development is still going on, but the last release was in 2015: miguelfreitas/twister-core#433

The daemon runs but I don't know how to test more.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc #68361

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 14, 2019
@WilliButz WilliButz merged commit f3d7447 into NixOS:master Sep 14, 2019
@WilliButz
Copy link
Member

backported in 4909a5e

@JohnAZoidberg JohnAZoidberg deleted the twister-openssl102 branch September 14, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnAZoidberg @WilliButz