Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chatterino{2,7}: pin boost to 1.86 #375928

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

NyCodeGHG
Copy link
Member

Upstream already released a patch1, but it's not yet released. It modifies submodules so it's difficult to apply, so we just use boost 1.86 until a new release is made.

Closes #375913

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Footnotes

  1. https://github.com/Chatterino/chatterino2/pull/5832/commits/ec728f3ca70f9b201e3108c91f44817f3e38d668

Upstream already released a patch[^1], but it's not yet released.
It modifies submodules so it's difficult to apply, so we just use boost
1.86 until a new release is made.

[^1]: Chatterino/chatterino2@ec728f3
@wineee wineee added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 23, 2025
@wineee wineee merged commit 38d195e into NixOS:master Jan 23, 2025
26 of 28 checks passed
@NyCodeGHG NyCodeGHG deleted the chatterino-boost branch January 23, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: chatterino2
3 participants