nixos/openvpn3: add /etc/openvpn3/configs to systemd.tmpfiles
#353832
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
JarvisCraft
force-pushed
the
openvpn3-statedir-systemd-tmpfile
branch
2 times, most recently
from
686e4e3
to
9200e18
Compare
name-snrl
reviewed
Nov 5, 2024
nixos/modules/programs/openvpn3.nix
Outdated
| systemd = { | ||
| packages = [ cfg.package ]; | ||
| tmpfiles.rules = [ | ||
| "d /etc/openvpn3/configs 0755 openvpn openvpn - -" |
There was a problem hiding this comment.
shouldn't this have 0750 permissions?
p.s. I don't know cpp at all :D
JarvisCraft
force-pushed
the
openvpn3-statedir-systemd-tmpfile
branch
from
9200e18
to
3f2bbfd
Compare
name-snrl
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of #326623 which added support for the fresh
openvpn3.This PR simply adds generation of the related
configsdirectory (namely/etc/openvpn3/configs) viasystemd.tmpfiles(at the current state ofmasteruser has to generate them manually which is wrong) as suggested by @name-snrl.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.