Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfn-nag: fix gemfile so that binaries are generated #353735

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mathstlouis
Copy link

@mathstlouis mathstlouis commented Nov 5, 2024

Binaries were not generated by previous update to 0.8.10:
#345859

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@surfaceflinger
Copy link
Member

Could you also set meta.mainProgram?

@mathstlouis
Copy link
Author

Could you also set meta.mainProgram?

Yes, added in c771f15

Also removed myself from maintainers since I'm not part of maintainer-list

@surfaceflinger
Copy link
Member

Also removed myself from maintainers since I'm not part of maintainer-list

feel free to add yourself, but add yourself to the maintainers file first before adding to package maintainers in a separate commit

Copy link
Member

@surfaceflinger surfaceflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested @ my work and it works fine!

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 5, 2024
@mathstlouis
Copy link
Author

Also removed myself from maintainers since I'm not part of maintainer-list

feel free to add yourself, but add yourself to the maintainers file first before adding to package maintainers in a separate commit

Done added in abcf5fb and 9642cf4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants