-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mautrix-signal: fix build with goolm, enable checks & version test #353730
base: master
Are you sure you want to change the base?
mautrix-signal: fix build with goolm, enable checks & version test #353730
Conversation
6792849
to
fbb6458
Compare
Seems to run fine so far on my own server. Interestingly much better than the last time I testdrove goolm! |
fbb6458
to
6461f4d
Compare
When building with goolm support, libstdc++ must be linked, as libsignal-ffi depends on it being linked. When building with (deprecated) libolm, it's pulled in transitively, it seems -- and it that case, this is effectively a no-op. Signed-off-by: Christoph Heiss <[email protected]>
Signed-off-by: Christoph Heiss <[email protected]>
Signed-off-by: Christoph Heiss <[email protected]>
6461f4d
to
fa2e57d
Compare
Thanks for reviewing & testing! |
If this runs sufficiently well, we could consider switching the default to |
Yeah, sounds like a good idea, since - as you say - already requires some form of intervention anyway. |
On current
master
, building mautrix-signal is broken when usingwitGoolm = true
, as it needs to explicitly link tolibstdc++
(which is transitivly required).Further, enable checks on the package, which only need a small workaround for properly finding
libstdc++
in the check phase -- hopefully that is acceptable, but maybe there is a better solution to this.Finally, add a basic version test for the resulting binary with
testers.testVersion
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.