Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvsp: init at 3.40.1 #353536

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

openvsp: init at 3.40.1 #353536

wants to merge 2 commits into from

Conversation

Kek5chen
Copy link

@Kek5chen Kek5chen commented Nov 3, 2024

The openvsp software package for nixpkgs.

Resolves #349534

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 3, 2024
@Kek5chen
Copy link
Author

Kek5chen commented Nov 3, 2024

uhm.. i'm pretty sure my package is properly formatted.. not according to nixfmt but comparing it to other packages... is nixfmt really the defacto or is it fine the way it is?

Also some thoughts about my custom phases:

OpenVSP comes packaged for Ubuntu and RPM based and on normal linux file structures it puts all its packages into /opt. I just extract the ones that I want. It's also a bit finicky because of it's urgent needs to package dynamic libraries. Any suggestions are appreciated.

Edit: Ah, finally figured it out while packaging another package. using nixfmt is not sufficient. using nixfmt-rfc-style is the way.. that's a bit weird, but alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: openvsp
1 participant