Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/build-helpers/testers: Fix command renamed to script #352713

Merged
merged 1 commit into from
Dec 4, 2024
Merged

doc/build-helpers/testers: Fix command renamed to script #352713

merged 1 commit into from
Dec 4, 2024

Conversation

Pandapip1
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 added the 3.skill: trivial This is trivial to complete (typically find-and-replace) label Oct 31, 2024
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Oct 31, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4784

@Pandapip1 Pandapip1 requested review from nbraud and roberth November 4, 2024 21:52
@Pandapip1
Copy link
Contributor Author

CC'd the people that last edited the section.

nbraud
nbraud approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch, and sorry for missing that in #333236 when I implemented and documented runCommand ❤️

@nbraud nbraud merged commit 67a56f2 into NixOS:master Dec 4, 2024
30 checks passed
@nbraud nbraud added the backport release-24.11 Backport PR automatically label Dec 4, 2024
@nix-backports
Copy link

nix-backports bot commented Dec 4, 2024

Successfully created backport PR for release-24.11:

nix-backports bot pushed a commit that referenced this pull request Dec 4, 2024
@Pandapip1 @github-actions
doc/build-helpers/testers: Fix command renamed to script (#352713)
44ddb26 
(cherry picked from commit 67a56f2)
@nix-backports nix-backports bot mentioned this pull request Dec 4, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbraud nbraud nbraud approved these changes

@roberth roberth Awaiting requested review from roberth

Assignees
No one assigned
Labels
3.skill: trivial This is trivial to complete (typically find-and-replace) 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pandapip1 @nixos-discourse @nbraud