python312Packages.openusd: fix build #351902

ShaddyDC · 2024-10-28T14:31:12Z

Changelog: https://github.com/PixarAnimationStudios/OpenUSD/blob/59992d2178afcebd89273759f2bddfe730e59aa8/CHANGELOG.md

This is not the latest version as the patch used isn't updated to that version yet.

I tested the basic functionality of some of the binaries.

6 packages built:
blender blender-hip blendfarm openusd python311Packages.openusd python312Packages.openusd

fixes #352873

Things done

Add a 👍 reaction to pull requests you find important.

nixos-discourse · 2024-10-31T08:10:58Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4780

dotlambda

Please rebase.
The commit message should start with python312Packages. and not talk about a version bump because 24.08 is already in master.

pkgs/development/python-modules/openusd/default.nix

nyabinary · 2024-11-03T14:35:35Z

In the changelog
"OpenUSD is now licensed under the Tomorrow Open Source Technology license. This is a renaming of the license, but the terms and conditions are the same as before. See this forum post for details."

So the license needs to be updated too.

gador · 2024-11-03T15:02:06Z

This fails to build with:

openusd> -- Configuring done (4.6s)
openusd> CMake Error at /nix/store/v6zrwwq9l9zdd3bdz6mqwvasc77mjkz8-python3.11-materialx-1.39.1/lib/cmake/MaterialX/MaterialXTargets.cmake:222 (set_target_properties):
openusd>   The link interface of target "MaterialXRender" contains:
openusd>
openusd>     OpenImageIO::OpenImageIO
openusd>
openusd>   but the target was not found.  Possible reasons include:
openusd>
openusd>     * There is a typo in the target name.
openusd>     * A find_package call is missing for an IMPORTED target.
openusd>     * An ALIAS target is missing.
openusd>
openusd> Call Stack (most recent call first):
openusd>   /nix/store/v6zrwwq9l9zdd3bdz6mqwvasc77mjkz8-python3.11-materialx-1.39.1/lib/cmake/MaterialX/MaterialXConfig.cmake:36 (include)
openusd>   cmake/defaults/Packages.cmake:315 (find_package)
openusd>   CMakeLists.txt:23 (include)
openusd>
openusd>
openusd> -- Generating done (0.9s)
openusd> CMake Warning:
openusd>   Manually-specified variables were not used by the project:
openusd>
openusd>     BUILD_TESTING
openusd>     CMAKE_INSTALL_BINDIR
openusd>     CMAKE_INSTALL_DOCDIR
openusd>     CMAKE_INSTALL_INCLUDEDIR
openusd>     CMAKE_INSTALL_INFODIR
openusd>     CMAKE_INSTALL_LIBDIR
openusd>     CMAKE_INSTALL_LIBEXECDIR
openusd>     CMAKE_INSTALL_LOCALEDIR
openusd>     CMAKE_INSTALL_MANDIR
openusd>     CMAKE_INSTALL_OLDINCLUDEDIR
openusd>     CMAKE_INSTALL_SBINDIR
openusd>     CMAKE_POLICY_DEFAULT_CMP0025
openusd>     PYSIDE_BIN_DIR
openusd>
openusd>
openusd> CMake Generate step failed.  Build files cannot be regenerated correctly.

gador · 2024-11-03T15:36:44Z

ok, this error is due the update of materialX in 993ec32 by @mweinelt
As I've said in #326466 (comment) materialX should not have been updated.
It may have been a good idea to go through a PR workflow and have me tagged in it. I then would have been able to catch that.

The only reasonable way forward in light of ZHF #352882 is to revert the update from the above commit.

I tested this PR with it and it builds fine, then.

gador · 2024-11-03T15:52:28Z

@ShaddyDC I piggybacked your PR here, did the rebase and added the new license. I hope thats ok.
@mweinelt could you have a look at this PR, as it also contains the revert of the material update and let me know, if you're ok with it?

mweinelt · 2024-11-03T15:54:58Z

The revert should contain the reason for which it was reverted.

amarshall

PR title needs to be updated, it doesn’t reflect what’s happening here anymore
Ideally the materialx revert should be first, otherwise the patch fix doesn’t actually fix the build

pkgs/development/python-modules/openusd/default.nix

This reverts commit 993ec32. MaterialX has some upstream issues which haven't been quite worked out, yet[1]. It is therefore reasonable to wait with an update in nixpkgs. It also breaks downstream packages like python312Packages.openusd as well as blender[2] [1]: PixarAnimationStudios/OpenUSD#3159 [2]: NixOS#326466 (comment) Signed-off-by: Florian Brandes <[email protected]>

Co-authored-by: ShadyDC <[email protected]> Signed-off-by: Florian Brandes <[email protected]>

Signed-off-by: Florian Brandes <[email protected]>

ShaddyDC · 2024-11-03T21:44:23Z

@gador thanks for taking this over! Those changes look good to me!

pkgs/development/python-modules/materialx/default.nix

pkgs/development/python-modules/openusd/default.nix

lib/licenses.nix

this adds the license for OpenUSD which is explained here https://forum.aousd.org/t/upcoming-openusd-license-update/1561 Signed-off-by: Florian Brandes <[email protected]>

Signed-off-by: Florian Brandes <[email protected]>

Atemu

Diff LGTM

pkgs/development/python-modules/openusd/default.nix

gador · 2024-11-04T10:35:15Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

`nixpkgs-review` result

⏩ 1 package blacklisted:

nixos-install-tools

✅ 9 packages built:

blender
blender-hip
blendfarm
materialx (python312Packages.materialx)
nixpkgs-manual
openusd
python311Packages.materialx
python311Packages.openusd
python312Packages.openusd

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

blender-hip-x86_64-linux:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/1j71lcyxcsn2pj4ajw7rskj15pa775vy-nixpkgs’ do not contain ‘blender-hip-x86_64-linux’ attribute.

blender-x86_64-linux:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/1j71lcyxcsn2pj4ajw7rskj15pa775vy-nixpkgs’ do not contain ‘blender-x86_64-linux’ attribute.

blendfarm-x86_64-linux:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/1j71lcyxcsn2pj4ajw7rskj15pa775vy-nixpkgs’ do not contain ‘blendfarm-x86_64-linux’ attribute.

materialx-x86_64-linux:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/1j71lcyxcsn2pj4ajw7rskj15pa775vy-nixpkgs’ do not contain ‘materialx-x86_64-linux’ attribute.

nixpkgs-manual-x86_64-linux:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/1j71lcyxcsn2pj4ajw7rskj15pa775vy-nixpkgs’ do not contain ‘nixpkgs-manual-x86_64-linux’ attribute.

openusd-x86_64-linux:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/1j71lcyxcsn2pj4ajw7rskj15pa775vy-nixpkgs’ do not contain ‘openusd-x86_64-linux’ attribute.

python311Packages.materialx-x86_64-linux:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/1j71lcyxcsn2pj4ajw7rskj15pa775vy-nixpkgs’ do not contain ‘python311Packages.materialx-x86_64-linux’ attribute.

python311Packages.openusd-x86_64-linux:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/1j71lcyxcsn2pj4ajw7rskj15pa775vy-nixpkgs’ do not contain ‘python311Packages.openusd-x86_64-linux’ attribute.

python312Packages.openusd-x86_64-linux:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/1j71lcyxcsn2pj4ajw7rskj15pa775vy-nixpkgs’ do not contain ‘python312Packages.openusd-x86_64-linux’ attribute.

gador · 2024-11-04T10:35:27Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

`nixpkgs-review` result

⏩ 1 package marked as broken and skipped:

blender

✅ 6 packages built:

materialx (python312Packages.materialx)
nixpkgs-manual
openusd
python311Packages.materialx
python311Packages.openusd
python312Packages.openusd

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

materialx-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/sj0krjxk6f39ys1znksm3cxhlk4q1d3j-nixpkgs’ do not contain ‘materialx-aarch64-darwin’ attribute.

nixpkgs-manual-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/sj0krjxk6f39ys1znksm3cxhlk4q1d3j-nixpkgs’ do not contain ‘nixpkgs-manual-aarch64-darwin’ attribute.

openusd-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/sj0krjxk6f39ys1znksm3cxhlk4q1d3j-nixpkgs’ do not contain ‘openusd-aarch64-darwin’ attribute.

python311Packages.materialx-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/sj0krjxk6f39ys1znksm3cxhlk4q1d3j-nixpkgs’ do not contain ‘python311Packages.materialx-aarch64-darwin’ attribute.

python311Packages.openusd-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/sj0krjxk6f39ys1znksm3cxhlk4q1d3j-nixpkgs’ do not contain ‘python311Packages.openusd-aarch64-darwin’ attribute.

python312Packages.openusd-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/sj0krjxk6f39ys1znksm3cxhlk4q1d3j-nixpkgs’ do not contain ‘python312Packages.openusd-aarch64-darwin’ attribute.

Signed-off-by: Florian Brandes <[email protected]>

philiptaron

Good by me.

github-actions bot added the 6.topic: python label Oct 28, 2024

ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 28, 2024

ShaddyDC mentioned this pull request Nov 1, 2024

Build failure: python311Packages.openusd #352873

Closed

dotlambda reviewed Nov 2, 2024

View reviewed changes

pkgs/development/python-modules/openusd/default.nix Show resolved Hide resolved

nyabinary added the 1.severity: legal This PR or issue raises or fixes a legal issue, e.g. licensing compliance label Nov 3, 2024

nyabinary mentioned this pull request Nov 3, 2024

How to deal with license compliance? #342570

Open

gador force-pushed the openusd-bump branch from e8ffd7c to ee31b41 Compare November 3, 2024 15:48

github-actions bot added the 6.topic: lib The Nixpkgs function library label Nov 3, 2024

nix-owners bot requested a review from alyssais November 3, 2024 15:49

gador force-pushed the openusd-bump branch from ee31b41 to 8f5271f Compare November 3, 2024 15:50

gador force-pushed the openusd-bump branch from 8f5271f to b892354 Compare November 3, 2024 15:58

amarshall reviewed Nov 3, 2024

View reviewed changes

pkgs/development/python-modules/openusd/default.nix Show resolved Hide resolved

pkgs/development/python-modules/openusd/default.nix Outdated Show resolved Hide resolved

gador changed the title ~~openusd: 24.05 -> 24.08~~ openusd: fix build Nov 3, 2024

gador force-pushed the openusd-bump branch from b892354 to 3b37195 Compare November 3, 2024 19:27

ShaddyDC and others added 2 commits November 3, 2024 20:48

python312Packages.openusd: apply upstream patch to fix build

3bea63b

Co-authored-by: ShadyDC <[email protected]> Signed-off-by: Florian Brandes <[email protected]>

python312Packages.openusd: conform to PEP 517

a886b69

Signed-off-by: Florian Brandes <[email protected]>

gador force-pushed the openusd-bump branch from 3b37195 to 1c70842 Compare November 3, 2024 19:48

ShaddyDC changed the title ~~openusd: fix build~~ python312Packages.openusd: fix build Nov 3, 2024

Scrumplex reviewed Nov 3, 2024

View reviewed changes

pkgs/development/python-modules/materialx/default.nix Show resolved Hide resolved

pkgs/development/python-modules/openusd/default.nix Show resolved Hide resolved

Atemu reviewed Nov 3, 2024

View reviewed changes

lib/licenses.nix Show resolved Hide resolved

lib/licenses.nix Outdated Show resolved Hide resolved

lib/licenses.nix Outdated Show resolved Hide resolved

lib/licenses.nix Show resolved Hide resolved

gador added 2 commits November 4, 2024 06:09

lib/licenses.nix: add tost

8f55121

this adds the license for OpenUSD which is explained here https://forum.aousd.org/t/upcoming-openusd-license-update/1561 Signed-off-by: Florian Brandes <[email protected]>

python312Packages.openusd: apply upsteam's new license

6924571

Signed-off-by: Florian Brandes <[email protected]>

gador force-pushed the openusd-bump branch from 1c70842 to 6924571 Compare November 4, 2024 05:10

Atemu approved these changes Nov 4, 2024

View reviewed changes

pkgs/development/python-modules/openusd/default.nix Outdated Show resolved Hide resolved

samueltardieu mentioned this pull request Nov 4, 2024

Build failure: python3.11-openusd-24.08.drv #353598

Closed

wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 4, 2024

ofborg bot requested a review from gador November 4, 2024 09:33

ofborg bot added 10.rebuild-linux: 11-100 and removed 10.rebuild-linux: 1-10 labels Nov 4, 2024

python312Packages.openusd: add gador as co-maintainer

e2a21bd

Signed-off-by: Florian Brandes <[email protected]>

philiptaron approved these changes Nov 4, 2024

View reviewed changes

philiptaron merged commit b8a2072 into NixOS:master Nov 4, 2024
11 of 12 checks passed

ShaddyDC deleted the openusd-bump branch November 5, 2024 08:52

ShaddyDC mentioned this pull request Nov 5, 2024

Build failure: blender/python3.11-openusd #353861

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python312Packages.openusd: fix build #351902

python312Packages.openusd: fix build #351902

ShaddyDC commented Oct 28, 2024 •

edited by dotlambda

Loading

nixos-discourse commented Oct 31, 2024

dotlambda left a comment

nyabinary commented Nov 3, 2024

gador commented Nov 3, 2024

gador commented Nov 3, 2024

gador commented Nov 3, 2024

mweinelt commented Nov 3, 2024 •

edited

Loading

amarshall left a comment

ShaddyDC commented Nov 3, 2024

Atemu left a comment

gador commented Nov 4, 2024

gador commented Nov 4, 2024

philiptaron left a comment

python312Packages.openusd: fix build #351902

python312Packages.openusd: fix build #351902

Conversation

ShaddyDC commented Oct 28, 2024 • edited by dotlambda Loading

Things done

nixos-discourse commented Oct 31, 2024

dotlambda left a comment

Choose a reason for hiding this comment

nyabinary commented Nov 3, 2024

gador commented Nov 3, 2024

gador commented Nov 3, 2024

gador commented Nov 3, 2024

mweinelt commented Nov 3, 2024 • edited Loading

amarshall left a comment

Choose a reason for hiding this comment

ShaddyDC commented Nov 3, 2024

Atemu left a comment

Choose a reason for hiding this comment

gador commented Nov 4, 2024

nixpkgs-review result

gador commented Nov 4, 2024

nixpkgs-review result

philiptaron left a comment

Choose a reason for hiding this comment

ShaddyDC commented Oct 28, 2024 •

edited by dotlambda

Loading

mweinelt commented Nov 3, 2024 •

edited

Loading

`nixpkgs-review` result

`nixpkgs-review` result