-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/hooks/xfce4-dev-tools: document hook #351512
Merged
Aleksanaa
merged 2 commits into
NixOS:master
from
tomodachi94:create/doc/hooks/xfce4-dev-tools
Nov 1, 2024
Merged
doc/hooks/xfce4-dev-tools: document hook #351512
Aleksanaa
merged 2 commits into
NixOS:master
from
tomodachi94:create/doc/hooks/xfce4-dev-tools
Nov 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomodachi94
added
8.has: documentation
6.topic: xfce
The Xfce Desktop Environment
labels
Oct 26, 2024
nix-owners
bot
requested review from
infinisil,
LeSuisse,
mweinelt,
philiptaron and
risicle
October 26, 2024 19:24
Also going to request a review from @bobby285271, who has done some work on this package in particular. (Aside: Feels like you should be in the Xfce team.) |
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Oct 26, 2024
bobby285271
reviewed
Oct 27, 2024
tomodachi94
force-pushed
the
create/doc/hooks/xfce4-dev-tools
branch
from
October 27, 2024 20:45
bb22f7d
to
265b120
Compare
tomodachi94
force-pushed
the
create/doc/hooks/xfce4-dev-tools
branch
from
October 28, 2024 03:09
265b120
to
d5794d5
Compare
bobby285271
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content looks correct for me, so the content LGTM 😂
tomodachi94
force-pushed
the
create/doc/hooks/xfce4-dev-tools
branch
from
October 31, 2024 21:48
d5794d5
to
7cfbd63
Compare
Aleksanaa
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: xfce
The Xfce Desktop Environment
8.has: documentation
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild
10.rebuild-linux: 1-10
10.rebuild-linux: 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #341479
Related: https://github.com/orgs/NixOS/projects/67/views/1?pane=issue&itemId=84912848
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.