Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/hooks/xfce4-dev-tools: document hook #351512

Merged

Conversation

tomodachi94
Copy link
Member

Part of #341479

Related: https://github.com/orgs/NixOS/projects/67/views/1?pane=issue&itemId=84912848

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tomodachi94 tomodachi94 requested a review from a team October 26, 2024 19:23
@tomodachi94 tomodachi94 added 8.has: documentation 6.topic: xfce The Xfce Desktop Environment labels Oct 26, 2024
@github-actions github-actions bot removed the 6.topic: xfce The Xfce Desktop Environment label Oct 26, 2024
@tomodachi94 tomodachi94 added the 6.topic: xfce The Xfce Desktop Environment label Oct 26, 2024
@tomodachi94
Copy link
Member Author

tomodachi94 commented Oct 26, 2024

Also going to request a review from @bobby285271, who has done some work on this package in particular.

(Aside: Feels like you should be in the Xfce team.)

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 26, 2024
doc/hooks/xfce4-dev-tools.section.md Outdated Show resolved Hide resolved
doc/hooks/xfce4-dev-tools.section.md Outdated Show resolved Hide resolved
@tomodachi94 tomodachi94 force-pushed the create/doc/hooks/xfce4-dev-tools branch from bb22f7d to 265b120 Compare October 27, 2024 20:45
@github-actions github-actions bot removed the 6.topic: xfce The Xfce Desktop Environment label Oct 27, 2024
@tomodachi94 tomodachi94 added the 6.topic: xfce The Xfce Desktop Environment label Oct 27, 2024
@tomodachi94 tomodachi94 force-pushed the create/doc/hooks/xfce4-dev-tools branch from 265b120 to d5794d5 Compare October 28, 2024 03:09
@github-actions github-actions bot removed the 6.topic: xfce The Xfce Desktop Environment label Oct 28, 2024
@tomodachi94 tomodachi94 added the 6.topic: xfce The Xfce Desktop Environment label Oct 28, 2024
Copy link
Member

@bobby285271 bobby285271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks correct for me, so the content LGTM 😂

doc/hooks/xfce4-dev-tools.section.md Outdated Show resolved Hide resolved
@tomodachi94 tomodachi94 force-pushed the create/doc/hooks/xfce4-dev-tools branch from d5794d5 to 7cfbd63 Compare October 31, 2024 21:48
@github-actions github-actions bot removed the 6.topic: xfce The Xfce Desktop Environment label Oct 31, 2024
@tomodachi94 tomodachi94 added the 6.topic: xfce The Xfce Desktop Environment label Oct 31, 2024
@Aleksanaa Aleksanaa merged commit 3ef9175 into NixOS:master Nov 1, 2024
12 of 13 checks passed
@tomodachi94 tomodachi94 deleted the create/doc/hooks/xfce4-dev-tools branch November 1, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: xfce The Xfce Desktop Environment 8.has: documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants