pyton312Packages.arelle: 18.3 -> 2.30.25, unbreak, refactor #337284
+194
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: clean-up
8.has: package (new)
ofborg
bot
added
11.by: package-maintainer
|
It's been ages since I've used this, so I haven't been a great maintainer for it. I hope you've fixed this because you need it, not because it was on a list of failed packages.
It wasn't very clean in the first place, so this is not a big loss. |
roberth
approved these changes
Aug 26, 2024
wegank
added
12.approvals: 1
13 tasks
TomaSajt
force-pushed
the
arelle
branch
3 times, most recently
from
c3fad98
to
4b98052
Compare
wegank
removed
12.approved-by: package-maintainer
|
Result of 16 packages built:
|
|
relevant for ZHF: #352882 |
|
@ofborg build python312Packages.arelle python312Packages.arelle.passthru.tests |
natsukium
reviewed
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The
arellepython package was very outdated, thesrc.revused no longer existed and the tests were failing on python 3.12 due toimpbeing used, so bumped the package version, refactored it and updated its dependencies.For generating the
docoutput, I had to add another dependency to nixpkgs:sphinx-autodoc2.For some reason
arelle'spyproject.tomluses~=when specifying the build-system deps, which is unfortunate, since we need to patch those out.Since this is a bigger change, I added myself as a maintainer.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.