Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracy: 0.10 -> 0.11.1 + other changes #328253

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

tracy: 0.10 -> 0.11.1 + other changes #328253

wants to merge 3 commits into from
+151 −111

Conversation

paveloom
Copy link
Member

@paveloom paveloom commented Jul 18, 2024 •
edited
Loading

Description of changes

https://github.com/wolfpld/tracy/releases/tag/v0.11.0
https://github.com/wolfpld/tracy/releases/tag/v0.11.1

Supersedes #320273. A follow up to #315205.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation 8.has: changelog labels Jul 18, 2024
@paveloom paveloom mentioned this pull request Jul 18, 2024
Closed
13 tasks
@paveloom paveloom changed the title tracy: 0.10 -> 0.11.0 + reformat tracy: 0.10 -> 0.11.0 + other changes Jul 18, 2024
@paveloom paveloom marked this pull request as ready for review July 18, 2024 20:13
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1 labels Jul 18, 2024
programotuojes added a commit to programotuojes/nixos-config that referenced this pull request Aug 12, 2024
@programotuojes
Add tracy
3286e88 
Copied from NixOS/nixpkgs#328253
@paveloom paveloom changed the title tracy: 0.10 -> 0.11.0 + other changes tracy: 0.10 -> 0.11.1 + other changes Aug 22, 2024
RobWalt
RobWalt approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@RobWalt RobWalt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just about to write the update when I spotted yours. I build it on my machine (tracy-wayland on x86_64-linux) and it works fine. Code also looks fine in my eyes but I'm not an nix expert either (!)

Thanks for this PR!

@carlthome
Copy link
Member

There's some conflicts blocking a merge, I assume. Would be nice to have this in!

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@jacereda
Copy link
Contributor

Thanks for working on this @paveloom

I've checked your changes, the conflicts are due to the stdenv.isXXX -> stdenv.hostPlatform.isXXX treewide rename. Just changing those will fix it. Tested it and it works fine. Could you rebase, please?

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 23, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzequielRamis EzequielRamis EzequielRamis left review comments

@RobWalt RobWalt RobWalt approved these changes

@shiryel shiryel shiryel approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@paveloom @carlthome @jacereda @RobWalt @shiryel @EzequielRamis @wegank