Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xtensor & xsimd updates #313306

Merged
merged 8 commits into from
May 22, 2024
Merged

xtensor & xsimd updates #313306

merged 8 commits into from
May 22, 2024

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar changed the title python311Packages.xtensor: always build tests {{python3Packages.,}xtensor,xsimd} updates May 21, 2024
@doronbehar doronbehar changed the title {{python3Packages.,}xtensor,xsimd} updates xtensor & xsimd updates May 21, 2024
@doronbehar doronbehar mentioned this pull request May 21, 2024
Closed
@ofborg ofborg bot requested review from cpcloud, tobim and lsix May 21, 2024 07:02
@doronbehar
Copy link
Contributor Author

I checked this change upon master at #312745, and CI is even green for x86_64-linux . I feel comfortable to let this cook in staging.

@doronbehar doronbehar merged commit 9d056f9 into NixOS:staging May 22, 2024
28 checks passed
@doronbehar doronbehar deleted the pkg/xsimd branch May 22, 2024 13:18
@vcunat
Copy link
Member

vcunat commented Jun 5, 2024

xsimd now fails on *-darwin:
https://hydra.nixos.org/build/262200221/nixlog/1/tail
https://hydra.nixos.org/build/262148581/nixlog/1/tail

/cc the staging-next PR #316075
nix-review-tools report hundreds of builds blocked by that

@doronbehar
Copy link
Contributor Author

Aish it's weird, this build passed when it was applied on branch master, here is the proof:

https://github.com/NixOS/nixpkgs/pull/312745/checks?check_run_id=25145368265

I opened an new upstream issue regarding this: xtensor-stack/xsimd#1030 .

Let's see if they will reply quick. If not, I have a Nixpkgs commit that disables the failing test for Darwin, that I will add to the staging-next PR (#316075).

@vcunat
Copy link
Member

vcunat commented Jun 5, 2024

Oh, maybe interaction with some other change. I just assumed that the update triggered the failure.

@doronbehar
Copy link
Contributor Author

Fix is in #317969 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud Awaiting requested review from cpcloud

@tobim tobim Awaiting requested review from tobim

@lsix lsix Awaiting requested review from lsix

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doronbehar @vcunat