Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chatterino{2,7}: pin boost to 1.86 #375928

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chatterino{2,7}: pin boost to 1.86 #375928

wants to merge 1 commit into from
+42 −34

Conversation

NyCodeGHG
Copy link
Member

Upstream already released a patch1, but it's not yet released. It modifies submodules so it's difficult to apply, so we just use boost 1.86 until a new release is made.

Closes #375913

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Footnotes

  1. https://github.com/Chatterino/chatterino2/pull/5832/commits/ec728f3ca70f9b201e3108c91f44817f3e38d668 ↩

@NyCodeGHG
chatterino{2,7}: pin boost to 1.86
2a6ca48 
Upstream already released a patch[^1], but it's not yet released.
It modifies submodules so it's difficult to apply, so we just use boost
1.86 until a new release is made.

[^1]: Chatterino/chatterino2@ec728f3
@nix-owners nix-owners bot requested a review from 0Supa January 22, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0Supa 0Supa 0Supa approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: chatterino2
2 participants
@NyCodeGHG @0Supa