Merge pull request #144 from NixOS/track_api_errors

add tracking for api errors
NixOS · Jan 6, 2025 · 095eaf3 · 095eaf3
2 parents 3018e16 + 3153719
commit 095eaf3
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/nixpkgs_merge_bot/commands/merge.py b/nixpkgs_merge_bot/commands/merge.py
@@ -108,7 +108,7 @@ def merge_command(issue_comment: IssueComment, settings: Settings) -> HttpRespon
         if check:
             one_merge_strategy_passed = True
             decline_reasons = []
-            continue
+            break
     for reason in decline_reasons:
         log.info(f"{issue_comment.issue_number}: {reason}")
 
@@ -167,6 +167,8 @@ def merge_command(issue_comment: IssueComment, settings: Settings) -> HttpRespon
                 return issue_response("merged")
             except GithubClientError as e:
                 log.exception(f"{issue_comment.issue_number}: merge failed")
+                msg = "GitHub API error (#371492):"  # Link Issue to track errors
+                decline_reasons.append(msg)
                 decline_reasons.extend(
                     [
                         f"@{issue_comment.commenter_login} merge failed:",