framework: refactor kmod for improved AMD support #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeniarose
force-pushed
the
framework-amd-kmod
branch
from
1e5489e
to
dac8121
Compare
xeniarose
changed the title
Mic92
reviewed
Jul 7, 2024
Mic92
reviewed
Jul 7, 2024
|
Bump :p |
xeniarose
force-pushed
the
framework-amd-kmod
branch
from
dac8121
to
80ff85f
Compare
|
kmod is not needed anymore in the upcoming kernels btw |
|
The kernel now fails to build with 6.11. |
There was a patch yesterday that landed on stable and unstable that makes it work on 6.11. Should be fine now, it's working on my machine. |
|
Awesome I will give it another go today. Thanks!
…On September 21, 2024 8:34:16 AM PDT, quatquatt ***@***.***> wrote:
> The kernel now fails to build with 6.11.
There was a patch yesterday that landed on stable and unstable that makes it work on 6.11. Should be fine now, it's working on my machine.
--
Reply to this email directly or view it on GitHub:
#1029 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
Changes several aspects of framework-laptop-kmod support: - default value has been changed to true when NixOS >= 24.05 and linux kernel >=6.10, and false otherwise - adds required patch for framework AMD enablement when kernel <6.10 - add README section describing usage
xeniarose
force-pushed
the
framework-amd-kmod
branch
from
80ff85f
to
f0dedf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #1028
Changes several aspects of framework-laptop-kmod support:
Also: this may be an upstream nixpkgs issue, but the lack of a good lore.kernel.org fetcher is kind of surprising. I tried using this sample code with
fetchpatchinitially, but got weird errors with it. I implemented afetchb4fetcher for my own personal usage, which usesb4to download and format patches from https://lore.kernel.org and the skeleton of that is present in this PR usingrunCommandfor simplicityThings done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake inputEdit: I've been running this on my own framework 16 for a bit now and everything seems to be working fine