Only restrict hidapi dependency on Linux #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We restrict the hidapi dependency to some specific versions to make sure that the hidraw backend is used, see: #602 But the hidapi versions that are now eligible are not providing wheels for Python 3.13 so that they have to be compiled from source. This is an unnecessary complication for non-Linux platforms. Therefore this patch only applies the restriction on Linux. Other platforms can use any 0.14 release.
robin-nitrokey
requested review from
daringer,
mmerklinger and
sosthene-nitrokey
sosthene-nitrokey
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We restrict the hidapi dependency to some specific versions to make sure that the hidraw backend is used, see:
#602
But the hidapi versions that are now eligible are not providing wheels for Python 3.13 so that they have to be compiled from source. This is an unnecessary complication for non-Linux platforms. Therefore this patch only applies the restriction on Linux. Other platforms can use any 0.14 release.