Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI coverage #612

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Improve CI coverage #612

merged 2 commits into from
Jan 10, 2025

Conversation

robin-nitrokey
Copy link
Member

This patch extends the CI to run nitropy --help on all supported Python versions to catch installation and basic runtime errors.

szszszsz
szszszsz approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@szszszsz szszszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
nitropy --help is enough in my case to reproduce the problem on Python 3.11.

@robin-nitrokey robin-nitrokey merged commit 78d6a04 into master Jan 10, 2025
18 checks passed
@robin-nitrokey robin-nitrokey deleted the ci branch January 10, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szszszsz szszszsz szszszsz approved these changes

@daringer daringer Awaiting requested review from daringer

@mmerklinger mmerklinger Awaiting requested review from mmerklinger

@sosthene-nitrokey sosthene-nitrokey Awaiting requested review from sosthene-nitrokey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robin-nitrokey @szszszsz