Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asn1crypto #582

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Remove asn1crypto #582

merged 3 commits into from
Oct 28, 2024

Conversation

sosthene-nitrokey
Copy link
Contributor

@sosthene-nitrokey sosthene-nitrokey commented Oct 25, 2024

removes the dependency on asn1crypto, replacing it with the cryptography package and a custom builder

Motivation

This is one less dependency. asn1crypto is not very widespread so using cryptography is likely the better solution.

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

  • tested with Python3.9
  • signed commits
  • updated documentation (e.g. parameter description, inline doc, docs.nitrokey)
  • added labels

Test Environment and Execution

  • OS: Arch Linux
  • device's model: NK3AM
  • device's firmware version: 1.7.0-test20241022

Relevant Output Example

Fixes #

Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use # type: ignore[<code>] to only ignore the problematic lints, otherwise LGTM.

@sosthene-nitrokey
Copy link
Contributor Author

Ok, it was failing because of a missing @property.

@sosthene-nitrokey sosthene-nitrokey merged commit 0dcc901 into master Oct 28, 2024
8 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the remove-asn1crypto branch October 28, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants