fido2 make-credential: Clenaup and add rk and uv options #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch migrates our make_credential implementation to use the webauthn types instead of a dict and removes all unused arguments from the fido2 make-credential subcommand.
This patch adds options to set the resident key and user verification requirement for the make-credential operation. Fixes: #462
robin-nitrokey
requested review from
daringer,
szszszsz and
sosthene-nitrokey
robin-nitrokey
changed the title
sosthene-nitrokey
approved these changes
Nov 8, 2023
daringer
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the make-credential command and adds support for setting a resident key and user verification requirement.