-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial nrf52_upload extraction from pc-nrfutil #346
Conversation
From technical point of view I would say this is fine for an initial working state. I added a README.md, maybe you could take a look, if this is ok from license point of view.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, I’d prefer to have this in a separate package to have a clean separation, otherwise looks good to me.
4098222
to
751ad16
Compare
windows tests still missing before we can merge ... ... separate package: |
* avoids importing pc-ble-driver-py * enables python 3.11 support * adds `pyserial` & `protobuf` to dependencies
The pynitrokey.nk3.bootloader.nrf52_upload module is imported from nrfutil and will be removed from this repository in an upcoming release. Therefore we disable the flake8 and mypy checks for it.
751ad16
to
9d9e078
Compare
Rebased onto master and added flake8 and mypy ignores to fix the CI. |
This PR replaces the
nrfutil
dependency with an extract from the originating, archived repository.Changes
nk3.bootloader.nrf52_upload
instead ofnrfutil
to upload a signed firmware to a Nitrokey 3 Mini (nRF52)pc-ble-driver-py
pyserial
&protobuf
to dependenciespackage.py
to create firmware images, although it is not usedblack
&isort
tonrf52_upload
Checklist
make check
ormake fix
for the formatting checkTest Environment and Execution
Fixes #330
Fixes #265