Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flexiber to the forked version #299

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Update flexiber to the forked version #299

merged 1 commit into from
Jun 22, 2023

Conversation

szszszsz
Copy link
Member

@szszszsz szszszsz commented Jun 22, 2023

The required patch is merged to upstream, but it was not released by tag, nor released on crates.io,
hence the tagged release use on fork.

This is a Secrets App dependency. The patch contains stability corrections (returns error, instead of panicking on unimplemented behavior).

Connected:

The required patch is merged to upstream, but it was
not released by tag, nor released on crates.io,
hence the tagged release use on fork.
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For unreleased upstream changes, using a commit hash is also fine for me.

@daringer
Copy link
Collaborator

lgtm, please add it to: #156 so we keep track of forked dependencies

@szszszsz
Copy link
Member Author

For unreleased upstream changes, using a commit hash is also fine for me.

That's unreadable though, unless accompanied with a comment

@szszszsz szszszsz merged commit 355531f into main Jun 22, 2023
@szszszsz szszszsz deleted the flexiber-patch branch June 22, 2023 11:37
@szszszsz
Copy link
Member Author

lgtm, please add it to: #156 so we keep track of forked dependencies

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants