Replace EncryptedSerializedCredential with EncryptedData #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
approved these changes
Dec 16, 2024
robin-nitrokey
force-pushed
the
credential-serde
branch
from
0d0b5ec to
f45a006
Compare
robin-nitrokey
changed the title
|
Updated to use the |
Previously, EncryptedSerializedCredential was a wrapper for trussed::api::reply::Encrypt. As we whave removed the serde trait implementations for the Trussed request and reply structs, this patch replaces the EncryptedSerializedCredential struct with the new trussed_core::types::EncryptedData helper type. See also: trussed-dev/trussed#183
robin-nitrokey
force-pushed
the
credential-serde
branch
from
f45a006 to
3095b8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, EncryptedSerializedCredential was a wrapper for trussed::api::reply::Encrypt. As we whave removed the serde trait implementations for the Trussed request and reply structs, this patch replaces the EncryptedSerializedCredential struct with the new trussed_core::types::EncryptedData helper type.
See also: trussed-dev/trussed#183