-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic config mechanism #7
Conversation
Example implementation in the runner: Nitrokey/nitrokey-3-firmware#337 |
Looks good! |
3461dd6
to
a40f6a7
Compare
Main changes since the initial implementation:
Still, a case could be made to use a backend instead so that applications can access changed configuration values without reboot. Though that would mean that applications need to be aware of the configuration mechanism. |
pynitrokey PR for testing: Nitrokey/pynitrokey#448 |
For that, could the |
lgtm |
This patch adds a generic configuration mechanism to the admin app. There are two new commands, GET_CONFIG and SET_CONFIG, that can be used to query and change configuration values by key. The runner is responsible for providing the configuration struct and a mapping from key to field.
93fd1d2
to
5a8aedd
Compare
This patch adds a generic configuration mechanism to the admin app. There are two new commands, GET_CONFIG and SET_CONFIG, that can be used to query and change configuration values by key. The runner is responsible for providing the configuration struct and a mapping from key to field.
Points to discuss: