Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix The 'importlib-resources; python_version < "3.9"' distribution was not found and is required by keyring #108

Merged
merged 22 commits into from
Jan 27, 2024

Conversation

NiklasRosenstein
Copy link
Owner

@NiklasRosenstein NiklasRosenstein commented Jan 27, 2024

In CI when using the GHA install action, we get this error always when running slap:

Traceback (most recent call last):
  File "/opt/pipx/venvs/slap-cli/lib/python3.10/site-packages/slap/application.py", line 249, in load_plugins
    plugin = loader()(self)
  File "/opt/pipx/venvs/slap-cli/lib/python3.10/site-packages/nr/util/plugins/_pkg_resources.py", line 78, in loader
    value = ep.load()
  File "/opt/pipx/shared/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2442, in load
    self.require(*args, **kwargs)
  File "/opt/pipx/shared/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2465, in require
    items = working_set.resolve(reqs, env, installer, extras=self.extras)
  File "/opt/pipx/shared/lib/python3.8/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'importlib-resources; python_version < "3.9"' distribution was not found and is required by keyring

The resolution is to not rely on pkg_resources anymore.

@NiklasRosenstein NiklasRosenstein marked this pull request as ready for review January 27, 2024 03:04
@NiklasRosenstein NiklasRosenstein merged commit c1d4c2e into develop Jan 27, 2024
@NiklasRosenstein NiklasRosenstein deleted the nr/debug-importlib-resources-dist-not-found branch January 27, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant