added fix for snowflake operator to accept authenticator and make parameters optional based on load_type #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added code to handle authenticator issue posted in issue #85
Added snowflake library installation to avoid initialization failures for brickflow plugins
enhanced the code to accept parameters based on load_type instead of making every parameter mandatory.
Related Issue
fix #85
Motivation and Context
At this point code is failing for user id's which require extra authentication mechanism which is blocking multiple brickflow consumers. As we added snowflake operator to initialize with brickflow_plugins it is looking for snowflake library and causing issues to some customers, fixing this issue. Current version of the operator expects optional parameters like sf_cluster_keys, incremental_filter, sf_grantee_roles even when they are not required for customers and causing issues.
How Has This Been Tested?
Created a wheel file , workflow and tested with user id that require and doesn't require extra authentication. ran multiple test cases with different combination of input params. created a notebook with operator code and ran multiple manual unit tests.
Screenshots (if appropriate):
Types of changes
Checklist: