Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed code gen for model to ensure that all tests pass #80

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

stikkireddy
Copy link
Collaborator

Description

Fixed the model to move from deprecated environments to targets

Related Issue

#77

Motivation and Context

This just updates the model to the latest version of the CLI

How Has This Been Tested?

Manual testing and unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@stikkireddy stikkireddy requested review from asingamaneni, newfront and a team as code owners January 10, 2024 17:00
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85ee1cd) 93.33% compared to head (1efbbef) 90.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   93.33%   90.20%   -3.14%     
==========================================
  Files          22       22              
  Lines        4919     3347    -1572     
==========================================
- Hits         4591     3019    -1572     
  Misses        328      328              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asingamaneni asingamaneni merged commit 09a2af9 into main Jan 10, 2024
3 of 4 checks passed
@asingamaneni asingamaneni deleted the fix/missing-data-security-mode-items branch January 10, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants