Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic 2.4 support #59

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

dannymeijer
Copy link
Member

@dannymeijer dannymeijer commented Nov 7, 2023

Description

  • Brings in support for pydantic 2.4
  • Loosens dependencies a bit, making it easier to install along with other libraries
  • Adds pylint and mypy sections to poetry configuration (pyproject.toml)
  • Disable apache-airflow (needs to be manually side loaded as poetry is unable to) - this because apache-airflow supports pydantic 2.*, but poetry's dependency resolced doesn't understand how to resolve it correctly
  • no new tests needed
  • Black configuration modernized (120 character width vs 88)

Related Issue

N/A

Motivation and Context

Want to bring in support for pydantic 2.4

How Has This Been Tested?

Unit tests and some integration tests with locally available projects that run against Brickflow

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ncies section, disable apache-airflow (needs to be manually side loaded as poetry is unable to)
@dannymeijer
Copy link
Member Author

updates:

  • reversed the line length change for black (left pylint alone to avoid having to update a bunch of docstrings)
  • fixed apache-airflow dependency

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d49ddac) 88.49% compared to head (e98d5d9) 88.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files          22       22           
  Lines        3189     3189           
=======================================
  Hits         2822     2822           
  Misses        367      367           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannymeijer
Copy link
Member Author

Please let me know when/if we can get a release around this PR. :)

@asingamaneni
Copy link
Collaborator

Please let me know when/if we can get a release around this PR. :)

One more PR pending from @stikkireddy , as it gets fixed we can do 1.0.0. We can target next week

@asingamaneni asingamaneni merged commit 0dc06b5 into Nike-Inc:main Nov 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants