-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to set timeout health check in workflows #58
Conversation
@brent-johnson looks like there are linting issues. Can you please run |
@asingamaneni Yep. Sorry about that. I'm not normally a python developer. I've added a commit that fixes the unit tests and formatting. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 88.48% 88.49%
=======================================
Files 22 22
Lines 3187 3189 +2
=======================================
+ Hits 2820 2822 +2
Misses 367 367
☔ View full report in Codecov by Sentry. |
Thanks much for creating the pr and making the changes. |
final missed formatting fix
b727bce
to
1e6cfd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enable health parameters to be passed into workflow and task to set timeout warning notifications
Description
added health option to Workflow class
How Has This Been Tested?
tests updated to cover new functional
dev test by deploying workflows to databricks with health option
Screenshots (if appropriate):
Types of changes
Checklist: