Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] 163 - For each task #185

Merged

Conversation

riccamini
Copy link
Contributor

Description

This PR adds support for for each task type

Related Issue

#163

Motivation and Context

The for each task was recently introduced in Databricks workflows as a way iterate tasks on a set of inout parameters. With this PR we will be able to use the for each task type in Brickflow defined workflows

How Has This Been Tested?

  • Unit tests of new methods added
  • codegen tests
  • examples deployed and run in databricks

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

riccamini and others added 29 commits December 2, 2024 15:42
refactor: DatabricksBundleCodegen to improve task handling and stream…
…ask type also in case of nested task being of Brickflow type
@riccamini riccamini marked this pull request as ready for review December 18, 2024 09:59
Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@asingamaneni asingamaneni merged commit c652522 into Nike-Inc:main Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants