[BUG] 182 - Fix brickflow deploy #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eation. Fixed wrong defaults for MultiProjectManager
riccamini
requested review from
asingamaneni,
stikkireddy,
newfront and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves #182.
Related Issue
Motivation and Context
PR introduced support for .yaml extension in project conf files. Because of a wrong defaults in MultiProjectManager (in combination with not providing the config file type in one of instance creation of MultiProjectManager), brickflow was trying to resolve .yaml config files instead of .yml
How Has This Been Tested?
Deployments from examples with both .yaml and .yml extensions
Screenshots (if appropriate):
Types of changes
Checklist: