Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Adjust logic for applying outcome for IF_ELSE_CONDITION tasks #173

Merged
merged 18 commits into from
Oct 21, 2024
Merged

[fix] Adjust logic for applying outcome for IF_ELSE_CONDITION tasks #173

merged 18 commits into from
Oct 21, 2024

Conversation

mikita-sakalouski
Copy link
Contributor

Description

  1. Add check that outcome is applied on correct task from dependencies
  2. Get correct outcome based on task key and not just first one

Related Issue

#172 #171

Motivation and Context

Get correct behavior

How Has This Been Tested?

Added more tasks into sample workflow for testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

mikita-sakalouski and others added 14 commits September 13, 2024 23:34
@mikita-sakalouski
Copy link
Contributor Author

Depends on #168 . Please firstly review and merge PR #168

@mikita-sakalouski mikita-sakalouski changed the title [FIX] Adjust logic for applying outcome for IF_ELSE_CONDITION tasks [fix] Adjust logic for applying outcome for IF_ELSE_CONDITION tasks Oct 18, 2024
newfront
newfront previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@newfront newfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikita-sakalouski There is a small fix that could simplify the block on engine/task.py - see my comment where we could remove the closing block since the yield {task_name: outcome} is the same on either side of the condition.

Otherwise this looks good to ship. :shipit:

pariksheet
pariksheet approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@pariksheet pariksheet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pariksheet pariksheet merged commit 039b74c into Nike-Inc:main Oct 21, 2024
2 checks passed
@mikita-sakalouski mikita-sakalouski deleted the fix/dependecy_on_conditional_tasks branch October 21, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pariksheet pariksheet pariksheet approved these changes

@asingamaneni asingamaneni Awaiting requested review from asingamaneni asingamaneni is a code owner

@stikkireddy stikkireddy Awaiting requested review from stikkireddy stikkireddy is a code owner

@newfront newfront Awaiting requested review from newfront newfront is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikita-sakalouski @newfront @pariksheet