Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spark_python_task support in Workflow #156

Merged
merged 8 commits into from
Sep 16, 2024

Conversation

mikita-sakalouski
Copy link
Contributor

@mikita-sakalouski mikita-sakalouski commented Sep 13, 2024

Description

Implement Spark Python task for existing model.

Related Issue

#26

Motivation and Context

Be aligned with Databricks native functionality and provide missed part.

How Has This Been Tested?

Add parts to bundles and several tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.53%. Comparing base (35d0824) to head (f330a99).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
brickflow/codegen/databricks_bundle.py 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   90.33%   91.53%   +1.19%     
==========================================
  Files          22       22              
  Lines        3384     4075     +691     
==========================================
+ Hits         3057     3730     +673     
- Misses        327      345      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asingamaneni asingamaneni self-requested a review September 16, 2024 22:24
Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution

@asingamaneni asingamaneni merged commit 1d6292f into Nike-Inc:main Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants