Refactoring randoms #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 13, 2013 15:05
GaussianConvolution) Refactored all operators to use the project's random instead of an external one. All tests still pass. Hoping they reflect use of random sufficiently.
Refactored super classes to use our utility.RandomGenerator.
RandomGenerator has the advantage of not needing to be assigned to a new variable if there aren't many places where it will be used. Perhaps you knew that. All tests pass.
|
DO NOT MERGE THIS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored all the instances of java.util.Random into utility.RandomGenerator.
For classes that only used the generator once or twice, I replaced those uses with RandomGenerator.[method used] and removed the variable assigned to the generator entirely. If there were multiple uses, or more than one kind of method called, I assigned their existing random-variable to RandomGenerator.generator.
A few problem subclasses had randoms hanging around unused. Those have been removed - the runners don't break and the tests still run, so I think this was okay.