-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] draft playing around with EVM codebase #2153
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request includes multiple changes to the
x/evm/keeper
andeth/rpc/pubsub
files to improve code clarity and functionality. The most important changes involve renaming variables for better readability, simplifying function signatures, and removing unnecessary return values.Codebase simplification:
x/evm/keeper/call_contract.go
: Simplified theCallContractWithInput
function by removing theevmObj
return value. [1] [2] [3] [4]x/evm/keeper/grpc_query.go
: Removed unnecessary return values in several functions, includingEthCall
,EstimateGasForEvmCallType
,TraceTx
,TraceCall
,TraceBlock
, andTraceEthTxMsg
. [1] [2] [3] [4] [5] [6]x/evm/keeper/msg_server.go
: Simplified theApplyEvmMsg
function by removing theevmObj
return value and renaming the function parameters for better readability. [1] [2] [3] [4] [5] [6]Variable renaming for better readability:
eth/rpc/pubsub/pubsub.go
: Renamed thename
parameter totopicName
in several functions to improve clarity. [1] [2] [3]Removal of unused code:
x/evm/keeper/keeper.go
: Removed theBaseFeeWeiPerGas
andTracer
functions as they were no longer needed.Minor bug fixes:
app/evmante/evmante_can_transfer.go
: Fixed a bug by usingctd.EVMKeeper.NewStateDB
instead ofctd.NewStateDB
.x/evm/keeper/funtoken_from_coin.go
: Removed an unnecessary return value in thedeployERC20ForBankCoin
function.# Purpose / Abstract