Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(evm): EVM fungible token protobufs and encoding tests #1936
feat(evm): EVM fungible token protobufs and encoding tests #1936
Changes from 7 commits
53c10bb
30fc64e
d65dfaf
9271ed0
e11195f
656e73f
b2286cf
ae624cb
351442a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more concise type description here that reads the field type from the generated code instead of "hard-coding" it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Robust error handling in
NewHexAddrFromStr
The function
NewHexAddrFromStr
includes comprehensive error checking to ensure that the input string is a valid ERC55-compliant address. This is crucial for avoiding issues related to invalid address formats being used throughout the system.Consider adding more detailed error messages or logging to assist in debugging if invalid addresses are provided.
Committable suggestion
Check warning on line 39 in eth/hex.go
Codecov / codecov/patch
eth/hex.go#L39
Check warning on line 67 in eth/hex.go
Codecov / codecov/patch
eth/hex.go#L66-L67
Check warning on line 95 in eth/hex.go
Codecov / codecov/patch
eth/hex.go#L90-L95
Check warning on line 111 in eth/hex.go
Codecov / codecov/patch
eth/hex.go#L111
Check warning on line 116 in eth/hex.go
Codecov / codecov/patch
eth/hex.go#L116