Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(geth): Reference go-ethereum as a submodule for easier change tracking with upstream #1895

Merged
merged 2 commits into from
May 23, 2024

Conversation

Unique-Divine
Copy link
Member

@Unique-Divine Unique-Divine commented May 23, 2024

Purpose / Abstract

This change will make it easier to merge in upstream changes from go-ethereum,
like security fixes, performance improvments, and future EIPs.

  • refactor(geth): Reference go-ethereum as a submodule for easier change tracking with upstream.
  • Migrates existing geth folder into the NibiruChain/go-ethereum repo.

@Unique-Divine Unique-Divine requested a review from a team as a code owner May 23, 2024 18:49
Copy link
Contributor

coderabbitai bot commented May 23, 2024

Walkthrough

The changes introduce a new submodule configuration for the geth module, referencing the go-ethereum repository. This refactoring allows for easier tracking and integration of upstream changes without altering any exported or public entity declarations.

Changes

File Change Summary
.gitmodules Introduced a submodule configuration for "geth" with a specific GitHub URL.
CHANGELOG.md Documented the refactoring to reference go-ethereum as a submodule.
geth Added a subproject commit with hash 7fb652f186b09b81cce9977408e1aff744f4e3ef.

🐇 In the garden of code, a new path we tread,
A submodule blooms where changes are fed.
With go-ethereum now in our sight,
Tracking upstream is a breeze, pure delight.

🌿✨ Happy coding!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 10cff9e and 16e35b9.
Files ignored due to path filters (79)
  • geth/accounts/keystore/testdata/v1_test_vector.json is excluded by !**/*.json
  • geth/accounts/keystore/testdata/v3_test_vector.json is excluded by !**/*.json
  • geth/accounts/keystore/testdata/very-light-scrypt.json is excluded by !**/*.json
  • geth/accounts/usbwallet/trezor/messages-common.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • geth/accounts/usbwallet/trezor/messages-ethereum.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • geth/accounts/usbwallet/trezor/messages-management.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • geth/accounts/usbwallet/trezor/messages.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • geth/appveyor.yml is excluded by !**/*.yml
  • geth/circle.yml is excluded by !**/*.yml
  • geth/cmd/clef/docs/clef_architecture_pt1.png is excluded by !**/*.png, !**/*.png
  • geth/cmd/clef/docs/clef_architecture_pt2.png is excluded by !**/*.png, !**/*.png
  • geth/cmd/clef/docs/clef_architecture_pt3.png is excluded by !**/*.png, !**/*.png
  • geth/cmd/clef/docs/clef_architecture_pt4.png is excluded by !**/*.png, !**/*.png
  • geth/cmd/clef/docs/qubes/clef_qubes_http.png is excluded by !**/*.png, !**/*.png
  • geth/cmd/clef/docs/qubes/clef_qubes_qrexec.png is excluded by !**/*.png, !**/*.png
  • geth/cmd/clef/docs/qubes/qrexec-example.png is excluded by !**/*.png, !**/*.png
  • geth/cmd/clef/docs/qubes/qubes_newaccount-1.png is excluded by !**/*.png, !**/*.png
  • geth/cmd/clef/docs/qubes/qubes_newaccount-2.png is excluded by !**/*.png, !**/*.png
  • geth/cmd/clef/sign_flow.png is excluded by !**/*.png, !**/*.png
  • geth/cmd/clef/testdata/sign_1559_missing_field_exp_fail.json is excluded by !**/*.json
  • geth/cmd/clef/testdata/sign_1559_missing_maxfeepergas_exp_fail.json is excluded by !**/*.json
  • geth/cmd/clef/testdata/sign_1559_tx.json is excluded by !**/*.json
  • geth/cmd/clef/testdata/sign_bad_checksum_exp_fail.json is excluded by !**/*.json
  • geth/cmd/clef/testdata/sign_normal_exp_ok.json is excluded by !**/*.json
  • geth/cmd/devp2p/internal/ethtest/testdata/genesis.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/1/alloc.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/1/env.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/1/exp.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/1/txs.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/10/alloc.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/10/env.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/10/txs.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/11/alloc.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/11/env.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/11/txs.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/12/alloc.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/12/env.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/12/txs.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/13/alloc.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/13/env.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/13/exp.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/13/exp2.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/13/txs.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/14/alloc.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/14/env.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/14/env.uncles.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/14/exp.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/14/exp2.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/14/exp_berlin.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/14/txs.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/15/exp.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/15/exp2.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/15/exp3.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/15/signed_txs.rlp.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/16/exp.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/16/unsigned_txs.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/17/exp.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/19/alloc.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/19/env.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/19/exp_arrowglacier.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/19/exp_grayglacier.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/19/exp_london.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/19/txs.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/2/alloc.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/2/env.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/2/txs.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/20/exp.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/20/header.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/20/ommers.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/21/clique.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/21/exp-clique.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/21/exp.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/21/header.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/21/ommers.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/22/exp-clique.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/22/exp.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/22/header.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/22/ommers.json is excluded by !**/*.json
  • geth/cmd/evm/testdata/23/alloc.json is excluded by !**/*.json
Files selected for processing (3)
  • .gitmodules (1 hunks)
  • CHANGELOG.md (1 hunks)
  • geth (1 hunks)
Files skipped from review due to trivial changes (2)
  • .gitmodules
  • geth
Additional Context Used
Markdownlint (1)
CHANGELOG.md (1)

63: Expected: 0 or 2; Actual: 1
Trailing spaces

Additional comments not posted (1)
CHANGELOG.md (1)

66-66: The changelog entry is clear and effectively communicates the changes made in the PR.

@Unique-Divine Unique-Divine added type: refactor dependencies Pull requests that update a dependency file labels May 23, 2024
@Unique-Divine Unique-Divine merged commit 969bccf into main May 23, 2024
18 checks passed
@Unique-Divine Unique-Divine deleted the ud/geth branch May 23, 2024 19:10
@Unique-Divine Unique-Divine added the x: evm Relates to Nibiru EVM or the EVM Module label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file x: evm Relates to Nibiru EVM or the EVM Module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant