-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(geth): Reference go-ethereum as a submodule for easier change tracking with upstream #1895
Conversation
WalkthroughThe changes introduce a new submodule configuration for the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (79)
geth/accounts/keystore/testdata/v1_test_vector.json
is excluded by!**/*.json
geth/accounts/keystore/testdata/v3_test_vector.json
is excluded by!**/*.json
geth/accounts/keystore/testdata/very-light-scrypt.json
is excluded by!**/*.json
geth/accounts/usbwallet/trezor/messages-common.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
geth/accounts/usbwallet/trezor/messages-ethereum.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
geth/accounts/usbwallet/trezor/messages-management.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
geth/accounts/usbwallet/trezor/messages.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
geth/appveyor.yml
is excluded by!**/*.yml
geth/circle.yml
is excluded by!**/*.yml
geth/cmd/clef/docs/clef_architecture_pt1.png
is excluded by!**/*.png
,!**/*.png
geth/cmd/clef/docs/clef_architecture_pt2.png
is excluded by!**/*.png
,!**/*.png
geth/cmd/clef/docs/clef_architecture_pt3.png
is excluded by!**/*.png
,!**/*.png
geth/cmd/clef/docs/clef_architecture_pt4.png
is excluded by!**/*.png
,!**/*.png
geth/cmd/clef/docs/qubes/clef_qubes_http.png
is excluded by!**/*.png
,!**/*.png
geth/cmd/clef/docs/qubes/clef_qubes_qrexec.png
is excluded by!**/*.png
,!**/*.png
geth/cmd/clef/docs/qubes/qrexec-example.png
is excluded by!**/*.png
,!**/*.png
geth/cmd/clef/docs/qubes/qubes_newaccount-1.png
is excluded by!**/*.png
,!**/*.png
geth/cmd/clef/docs/qubes/qubes_newaccount-2.png
is excluded by!**/*.png
,!**/*.png
geth/cmd/clef/sign_flow.png
is excluded by!**/*.png
,!**/*.png
geth/cmd/clef/testdata/sign_1559_missing_field_exp_fail.json
is excluded by!**/*.json
geth/cmd/clef/testdata/sign_1559_missing_maxfeepergas_exp_fail.json
is excluded by!**/*.json
geth/cmd/clef/testdata/sign_1559_tx.json
is excluded by!**/*.json
geth/cmd/clef/testdata/sign_bad_checksum_exp_fail.json
is excluded by!**/*.json
geth/cmd/clef/testdata/sign_normal_exp_ok.json
is excluded by!**/*.json
geth/cmd/devp2p/internal/ethtest/testdata/genesis.json
is excluded by!**/*.json
geth/cmd/evm/testdata/1/alloc.json
is excluded by!**/*.json
geth/cmd/evm/testdata/1/env.json
is excluded by!**/*.json
geth/cmd/evm/testdata/1/exp.json
is excluded by!**/*.json
geth/cmd/evm/testdata/1/txs.json
is excluded by!**/*.json
geth/cmd/evm/testdata/10/alloc.json
is excluded by!**/*.json
geth/cmd/evm/testdata/10/env.json
is excluded by!**/*.json
geth/cmd/evm/testdata/10/txs.json
is excluded by!**/*.json
geth/cmd/evm/testdata/11/alloc.json
is excluded by!**/*.json
geth/cmd/evm/testdata/11/env.json
is excluded by!**/*.json
geth/cmd/evm/testdata/11/txs.json
is excluded by!**/*.json
geth/cmd/evm/testdata/12/alloc.json
is excluded by!**/*.json
geth/cmd/evm/testdata/12/env.json
is excluded by!**/*.json
geth/cmd/evm/testdata/12/txs.json
is excluded by!**/*.json
geth/cmd/evm/testdata/13/alloc.json
is excluded by!**/*.json
geth/cmd/evm/testdata/13/env.json
is excluded by!**/*.json
geth/cmd/evm/testdata/13/exp.json
is excluded by!**/*.json
geth/cmd/evm/testdata/13/exp2.json
is excluded by!**/*.json
geth/cmd/evm/testdata/13/txs.json
is excluded by!**/*.json
geth/cmd/evm/testdata/14/alloc.json
is excluded by!**/*.json
geth/cmd/evm/testdata/14/env.json
is excluded by!**/*.json
geth/cmd/evm/testdata/14/env.uncles.json
is excluded by!**/*.json
geth/cmd/evm/testdata/14/exp.json
is excluded by!**/*.json
geth/cmd/evm/testdata/14/exp2.json
is excluded by!**/*.json
geth/cmd/evm/testdata/14/exp_berlin.json
is excluded by!**/*.json
geth/cmd/evm/testdata/14/txs.json
is excluded by!**/*.json
geth/cmd/evm/testdata/15/exp.json
is excluded by!**/*.json
geth/cmd/evm/testdata/15/exp2.json
is excluded by!**/*.json
geth/cmd/evm/testdata/15/exp3.json
is excluded by!**/*.json
geth/cmd/evm/testdata/15/signed_txs.rlp.json
is excluded by!**/*.json
geth/cmd/evm/testdata/16/exp.json
is excluded by!**/*.json
geth/cmd/evm/testdata/16/unsigned_txs.json
is excluded by!**/*.json
geth/cmd/evm/testdata/17/exp.json
is excluded by!**/*.json
geth/cmd/evm/testdata/19/alloc.json
is excluded by!**/*.json
geth/cmd/evm/testdata/19/env.json
is excluded by!**/*.json
geth/cmd/evm/testdata/19/exp_arrowglacier.json
is excluded by!**/*.json
geth/cmd/evm/testdata/19/exp_grayglacier.json
is excluded by!**/*.json
geth/cmd/evm/testdata/19/exp_london.json
is excluded by!**/*.json
geth/cmd/evm/testdata/19/txs.json
is excluded by!**/*.json
geth/cmd/evm/testdata/2/alloc.json
is excluded by!**/*.json
geth/cmd/evm/testdata/2/env.json
is excluded by!**/*.json
geth/cmd/evm/testdata/2/txs.json
is excluded by!**/*.json
geth/cmd/evm/testdata/20/exp.json
is excluded by!**/*.json
geth/cmd/evm/testdata/20/header.json
is excluded by!**/*.json
geth/cmd/evm/testdata/20/ommers.json
is excluded by!**/*.json
geth/cmd/evm/testdata/21/clique.json
is excluded by!**/*.json
geth/cmd/evm/testdata/21/exp-clique.json
is excluded by!**/*.json
geth/cmd/evm/testdata/21/exp.json
is excluded by!**/*.json
geth/cmd/evm/testdata/21/header.json
is excluded by!**/*.json
geth/cmd/evm/testdata/21/ommers.json
is excluded by!**/*.json
geth/cmd/evm/testdata/22/exp-clique.json
is excluded by!**/*.json
geth/cmd/evm/testdata/22/exp.json
is excluded by!**/*.json
geth/cmd/evm/testdata/22/header.json
is excluded by!**/*.json
geth/cmd/evm/testdata/22/ommers.json
is excluded by!**/*.json
geth/cmd/evm/testdata/23/alloc.json
is excluded by!**/*.json
Files selected for processing (3)
- .gitmodules (1 hunks)
- CHANGELOG.md (1 hunks)
- geth (1 hunks)
Files skipped from review due to trivial changes (2)
- .gitmodules
- geth
Additional Context Used
Markdownlint (1)
CHANGELOG.md (1)
63: Expected: 0 or 2; Actual: 1
Trailing spaces
Additional comments not posted (1)
CHANGELOG.md (1)
66-66
: The changelog entry is clear and effectively communicates the changes made in the PR.
Purpose / Abstract
This change will make it easier to merge in upstream changes from go-ethereum,
like security fixes, performance improvments, and future EIPs.
geth
folder into the NibiruChain/go-ethereum repo.