-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make Gen_market set initial perp versions #1677
Conversation
WalkthroughA new pull request has been merged, enhancing the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- x/perp/v2/client/cli/gen_market.go (1 hunks)
Additional comments: 2
CHANGELOG.md (1)
- 91-94: The changelog correctly documents the addition of pull request fix: make Gen_market set initial perp versions #1677, which fixes an issue with the
Gen_market
command by setting initial perpetual versions.x/perp/v2/client/cli/gen_market.go (1)
- 80-95:
Ensure that theVersion
field of eachmarket
inperpGenState.Markets
is being set correctly before this code block is executed, as it relies on that field to populateMarketLastVersions
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional comments: 1
CHANGELOG.md (1)
- 92-95: The changelog correctly documents the addition of pull request fix: make Gen_market set initial perp versions #1677, which fixes an issue with the
Gen_market
component by setting initial perpetual versions.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1677 +/- ##
==========================================
+ Coverage 73.75% 73.92% +0.16%
==========================================
Files 192 192
Lines 15388 15398 +10
==========================================
+ Hits 11350 11383 +33
+ Misses 3379 3355 -24
- Partials 659 660 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- x/perp/v2/types/genesis.go (1 hunks)
Additional comments: 1
x/perp/v2/types/genesis.go (1)
- 19-22: The addition of the
CollateralDenom
field to theDefaultGenesis
function is a significant change. Ensure that all relevant documentation, tests, and dependent modules are updated to reflect this new field in the genesis state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- x/perp/v2/types/genesis_test.go (1 hunks)
Additional comments: 1
x/perp/v2/types/genesis_test.go (1)
- 25-28: The test
TestDefaultGenesis
has been updated to check for a non-nilCollateralDenom
. This change aligns with the new expectation thatCollateralDenom
should have a value in the default genesis state. Ensure that the default genesis state is correctly initializingCollateralDenom
with a non-empty value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional comments: 1
CHANGELOG.md (1)
- 93-96: The addition of pull request fix: make Gen_market set initial perp versions #1677 in the
CHANGELOG.md
under "Bug Fixes" correctly documents the critical fix for initializing market and AMM last versions in theGen_market
component.
Description
Gen market cli call does not set up the market and amms last version, causing every GetMarket to fail.
Purpose
Fix localnet mainly
Summary by CodeRabbit
New Features
Documentation