Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wasm): bump wasmd dependency to v0.43.0 #1660

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Conversation

k-yang
Copy link
Member

@k-yang k-yang commented Nov 3, 2023

Description

Bumps wasmd to v0.43.0

Purpose

Our previous version of wasmd v0.40.2 was old.

@k-yang k-yang marked this pull request as ready for review November 3, 2023 18:29
@k-yang k-yang requested a review from a team as a code owner November 3, 2023 18:29
@k-yang k-yang enabled auto-merge (squash) November 3, 2023 18:30
@Unique-Divine
Copy link
Member

Unique-Divine commented Nov 3, 2023

It looks like the linter doesn't want the aliased imports. The error comes from here, but it's not actually causing a bug.

Want to merge it as is, or should we appease the linter?

The fix is to directly import things from wasm/keeper rather than from wasm

image

@k-yang
Copy link
Member Author

k-yang commented Nov 3, 2023

It looks like the linter doesn't want the aliased imports. The error comes from here, but it's not actually causing a bug.

Want to merge it as is, or should we appease the linter?

The fix is to directly import things from wasm/keeper rather than from wasm

image

I can fix it

@k-yang k-yang disabled auto-merge November 3, 2023 20:34
@k-yang k-yang marked this pull request as draft November 3, 2023 20:34
@matthiasmatt matthiasmatt marked this pull request as ready for review November 6, 2023 17:58
@matthiasmatt matthiasmatt merged commit 9076725 into master Nov 6, 2023
16 checks passed
@matthiasmatt matthiasmatt deleted the chore/bump/wasmd branch November 6, 2023 17:59
k-yang added a commit that referenced this pull request Nov 6, 2023
* chore(wasm): bump wasmd dependency to v0.43.0

* Update CHANGELOG.md

* fix: fix linter issues

---------

Co-authored-by: Matthias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants