feat(perp): Make the collateral denom a stateful collections.Item #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d network migration
…biru into mat/make-quote-collection
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1656 +/- ##
==========================================
- Coverage 74.19% 73.82% -0.37%
==========================================
Files 191 192 +1
Lines 15114 15211 +97
==========================================
+ Hits 11214 11230 +16
- Misses 3264 3329 +65
- Partials 636 652 +16
|
Unique-Divine
requested changes
Nov 13, 2023
…Chain/nibiru into mat/make-quote-collection
Unique-Divine
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Final note: All suggested changes have been addressed excepting #1656 (comment)
Unique-Divine
approved these changes
Nov 15, 2023
Unique-Divine
added
duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a collateral object to use instead of the quote denom. Collateral is then accessed through Collateral[QuoteDenom]
MsgChangeCollateralDenomto the perpMsgServer, gated behindSudoKeeper.CheckPermissionsPurpose
The collateral denom for x/perp needs to be a collections.Item / KeySet to make it configurable.
This is necessary for setting the address for NUSD, which would look like "tf/[contract-addr]/nusd".
This change would also lower the possibility of mistakes arising from hard-coded denominations on all of the bank transfer logic in x/perp.
collections.Item#1640