test: refactors cli.network suites with 'Integration' to use common function #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/NibiruChain/nibiru into realu/consistent-integration-suite
Codecov Report
@@ Coverage Diff @@
## master #1652 +/- ##
==========================================
+ Coverage 74.25% 74.28% +0.02%
==========================================
Files 191 191
Lines 15099 15096 -3
==========================================
+ Hits 11212 11214 +2
+ Misses 3256 3251 -5
Partials 631 631
|
Unique-Divine
commented
Oct 28, 2023
Comment on lines
24
to
+25
| - name: Run all unit tests. | ||
| run: make test-coverage | ||
| run: make test-unit |
There was a problem hiding this comment.
In the unit-test.yml GitHub action, there's no reason to save a coverage.txt since it's not published or visible. We're only using the reports from the integration-test.yml action. We can use make test-unit here to have the CI run faster.
Unique-Divine
commented
Oct 28, 2023
Comment on lines
-7
to
+9
| .PHONY: test-coverage | ||
| test-coverage: | ||
| go test ./... $(PACKAGES_NOSIMULATION) -short \ | ||
| .PHONY: test-coverage-unit |
There was a problem hiding this comment.
Using $PACKAGES_NOSIMULATION is unnecessary since simulations require a specific flag and we're already using the -short flag, which can filter out simulations
Unique-Divine
commented
Oct 29, 2023
…om/NibiruChain/nibiru into realu/consistent-integration-suite
jgimeno
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes our implementation of the convention for skipping network tests with
testing.shortand the-shortflag consistent across modules.Makes it so that simulations (
simapptests) are filtered out without us needing to usego list. As can be seen incontrib/make/simulation.mk, the simulation tests use an-Enabled=trueflag in setup and aren't considered unit tests (using the-shortflag). Their setup can follow the same convention as the integration tests by callingtestutil.BeforeIntegrationSuite.ci: In the
unit-test.ymlGitHub action, there's no reason to save a coverage.txt since it's not published or visible from outside the workflow. We're only using the reports fromintegration-test.yml, so it makes sense to usemake test-unithere and have the action run faster.Purpose
This change makes the code less repetitive and easier to maintain by having the doc comment on a common function.
Unit tests run in 3-6 minutes now instead of 8+ min.
This will fix the false-alarm CI failures resulting from
cli.Networktests running when they shouldn't be. For example, https://github.com/NibiruChain/nibiru/actions/runs/6566058545/job/17835937660?pr=1643:[Expand example block]