test(perp): TestTransferFee (#666)

NibiruChain · Jun 29, 2022 · bb2f7e8 · bb2f7e8
1 parent 415e07a
commit bb2f7e8
Show file tree

Hide file tree

Showing 2 changed files with 75 additions and 1 deletion.
diff --git a/x/perp/keeper/clearing_house.go b/x/perp/keeper/clearing_house.go
@@ -780,7 +780,6 @@ func (k Keeper) ClosePosition(ctx sdk.Context, pair common.AssetPair, addr sdk.A
 	return positionResp, nil
 }
 
-// TODO test: transferFee | https://github.com/NibiruChain/nibiru/issues/299
 func (k Keeper) transferFee(
 	ctx sdk.Context,
 	pair common.AssetPair,

diff --git a/x/perp/keeper/clearing_house_test.go b/x/perp/keeper/clearing_house_test.go
@@ -2160,6 +2160,81 @@ func TestCloseAndOpenReversePosition(t *testing.T) {
 	}
 }
 
+func TestTransferFee(t *testing.T) {
+	setup := func() (
+		k Keeper, mocks mockedDependencies, ctx sdk.Context, pair common.AssetPair,
+		trader sdk.AccAddress, positionNotional sdk.Dec,
+	) {
+		perpKeeper, mocks, ctx := getKeeper(t)
+		pair = common.MustNewAssetPair("btc:usdc")
+		perpKeeper.SetParams(ctx, types.DefaultParams())
+		metadata := &types.PairMetadata{
+			Pair: pair.String(),
+		}
+		perpKeeper.PairMetadataState(ctx).Set(metadata)
+		trader = sample.AccAddress()
+		positionNotional = sdk.NewDec(5_000)
+		return perpKeeper, mocks, ctx, pair, trader, positionNotional
+	}
+
+	t.Run("trader has funds - happy",
+		func(t *testing.T) {
+			k, mocks, ctx, pair, trader, positionNotional := setup()
+
+			var wantError error = nil
+			mocks.mockBankKeeper.EXPECT().SendCoinsFromAccountToModule(
+				ctx, trader, types.FeePoolModuleAccount,
+				sdk.NewCoins(sdk.NewInt64Coin(pair.GetQuoteTokenDenom(), 5)),
+			).Return(wantError)
+			mocks.mockBankKeeper.EXPECT().SendCoinsFromAccountToModule(
+				ctx, trader, types.PerpEFModuleAccount,
+				sdk.NewCoins(sdk.NewInt64Coin(pair.GetQuoteTokenDenom(), 5)),
+			).Return(wantError)
+
+			_, err := k.transferFee(
+				ctx, pair, trader, positionNotional)
+			require.NoError(t, err)
+		})
+
+	t.Run("not enough funds for Perp Ecosystem Fund (spread) - error",
+		func(t *testing.T) {
+			k, mocks, ctx, pair, trader, positionNotional := setup()
+
+			mocks.mockBankKeeper.EXPECT().SendCoinsFromAccountToModule(
+				ctx, trader, types.FeePoolModuleAccount,
+				sdk.NewCoins(sdk.NewInt64Coin(pair.GetQuoteTokenDenom(), 5)),
+			).Return(nil)
+
+			expectedError := fmt.Errorf(
+				"trader missing funds for %s", types.PerpEFModuleAccount)
+			mocks.mockBankKeeper.EXPECT().SendCoinsFromAccountToModule(
+				ctx, trader, types.PerpEFModuleAccount,
+				sdk.NewCoins(sdk.NewInt64Coin(pair.GetQuoteTokenDenom(), 5))).
+				Return(expectedError)
+			_, err := k.transferFee(
+				ctx, pair, trader, positionNotional)
+			require.ErrorContains(t, err, expectedError.Error())
+		})
+
+	t.Run("not enough funds for Fee Pool (toll) - error",
+		func(t *testing.T) {
+			k, mocks, ctx, pair, trader, positionNotional := setup()
+
+			expectedError := fmt.Errorf(
+				"trader missing funds for %s", types.FeePoolModuleAccount)
+			mocks.mockBankKeeper.EXPECT().SendCoinsFromAccountToModule(
+				ctx,
+				/* from */ trader,
+				/* to */ types.FeePoolModuleAccount,
+				sdk.NewCoins(sdk.NewInt64Coin(pair.GetQuoteTokenDenom(), 5)),
+			).Return(expectedError)
+
+			_, err := k.transferFee(
+				ctx, pair, trader, positionNotional)
+			require.ErrorContains(t, err, expectedError.Error())
+		})
+}
+
 func TestClosePosition(t *testing.T) {
 	tests := []struct {
 		name string