Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(token-vesting): strong error types, explicit checks in tests, and deregister tests #83

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

Unique-Divine
Copy link
Member


  • ci: Exclude prost types from nibiru-std/src/proto/buf from coverage + fmt
  • feat(nibiru-std): implement NibiruStargateQuery as an extension of prost::Nme
  • test(nibiru-std): verify that CosmosMsg::Stargate types error when converted to QueryRequest::Stargate
  • test(token-vesting): add tests for execute deregister
  • test(token-vesting): clean up linear vesting tests
  • test(token-vesting): use strongly-typed, idiomatic errors
  • test(token-vesting): use typed errors + Result types in contract.rs
  • test(token-vesting): use explicit error comparisons in tests + Result types in testing.rs

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Files Coverage Δ
contracts/token-vesting/src/errors.rs 100.00% <100.00%> (ø)
contracts/token-vesting/src/contract.rs 96.51% <96.12%> (+22.55%) ⬆️
contracts/token-vesting/src/msg.rs 88.76% <88.23%> (-1.62%) ⬇️
contracts/token-vesting/src/testing.rs 98.89% <96.31%> (-0.06%) ⬇️

📢 Thoughts on this report? Let us know!.

@Unique-Divine Unique-Divine merged commit ac45814 into main Oct 24, 2023
5 checks passed
@Unique-Divine Unique-Divine deleted the realu/vesting-tests branch October 24, 2023 08:08
@Unique-Divine Unique-Divine added type: refactor A code change that neither fixes a bug nor adds a feature type: test Adds missing tests or improves existing tests labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor A code change that neither fixes a bug nor adds a feature type: test Adds missing tests or improves existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(vesting): deregister code path needs unit tests
1 participant