탭 바 & 뷰 구조 작성 #35
Merged
탭 바 & 뷰 구조 작성 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enebin
force-pushed
the
feature/add-tabbar(#28)
branch
from
60b4037
to
b472bfd
Compare
|
PR Diff가 너무 많아졌네요.. 다음부턴 200 내외로 끊어보도록 하겠습니다. 제성합니다..... 😢 |
enebin
commented
Aug 10, 2023
Projects/Features/Sources/KeymeServiceStatus/KeymeServiceStatusFeature.swift
Outdated
Show resolved
Hide resolved
Closed
k906506
reviewed
Aug 11, 2023
Projects/Features/Sources/KeymeServiceStatus/KeymeServiceStatusFeature.swift
Outdated
Show resolved
Hide resolved
Projects/Features/Sources/KeymeServiceStatus/KeymeServiceStatusFeature.swift
Outdated
Show resolved
Hide resolved
0inn
reviewed
Aug 12, 2023
There was a problem hiding this comment.
일단 코드는 바뀔 가능성이 너무 많아보여서 전체적인 컨벤션만 코멘트 달아둘게 !
먼저 내가 생각했던 모듈 분리랑 폴더링은
Keyme(앱의 시작점) - App, Root(폴더) - RootFeature(Store), RootView(View)
Features(우리가 작업하는 피처들) - Login(폴더) - LoginFeature(Store), LoginView(View)
이런식으로 가져가는 방향이었어.
파일 네이밍도 통일하면 좋을 것 같은데
View랑 Feature로 가는건가 ?
그럼 파일 네이밍도 OnboardingFeature이런식으로 가면 좋을 것 같아.
그리고 View랑 Store는 결국 1:1 대응으로 가져가는 거니까
둘의 네이밍도 같게 가져가는게 어때 ? ex) RootView, RootFeature
enebin
force-pushed
the
feature/add-tabbar(#28)
branch
from
b0d705d
to
3885d30
Compare
|
@0inn 폴더 구조 확인 한 번만! |
0inn
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
스샷
진행한 것
참고
로그인, 온보딩 페이지를 비워놓았으니 나중에 거기를 채워주시면 되겠습니다.
테스트..테스트는.. 시간 남으면 붙이겠음. 언제 또 바뀔지 모르겠어서.
closes [공통] 탭 바 설정 #28, [공통] 앱 처음 실행 시 유저 플로우 구현 #36