Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/onboarding invitation UI #18

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Conversation

eshc123
Copy link
Member

@eshc123 eshc123 commented Aug 5, 2024

주요내용

  • 초대코드 입력 화면 추가
  • 입력 후 미션 내용 확인 다이얼로그 추가
  • MissionMateDialog 일부 수정
    • content를 받을 때 content가 길어져서 스크롤이 생길 경우를 대비하여 Column 구조 수정
    • 누락된 onClickOk 와 cancel 클릭 추가

@eshc123 eshc123 requested a review from bywindow August 5, 2024 13:51
@eshc123 eshc123 self-assigned this Aug 5, 2024
CodeActionEvent.FIRST_DONE,
CodeActionEvent.SECOND_DONE,
CodeActionEvent.THIRD_DONE -> {
delay(80)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 딜레이는 뷰 포커싱 때문에 있는거지?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

응, 바로 포커싱을 바꾸려고 하니 제대로 못 잡기도 하고 알 수 없는 이슈가 생겼는데 딜레이를 주고 나니 이슈가 사라져서 우선 이렇게 적용해봤어! 이후에 원인을 한번 찾아보긴 해야할 것 같아..!

@eshc123 eshc123 merged commit 210b5b8 into dev Aug 6, 2024
1 check passed
@eshc123 eshc123 deleted the feature/onboarding-invitation-ui branch August 6, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants