-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type hierarchy for CorrectedImageStack, ImagingRetinotopy; improve docs #962
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #962 +/- ##
=======================================
Coverage 72.93% 72.93%
=======================================
Files 36 36
Lines 2609 2609
Branches 497 497
=======================================
Hits 1903 1903
Misses 590 590
Partials 116 116
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #962 +/- ##
======================================
Coverage ? 73.24%
======================================
Files ? 36
Lines ? 2616
Branches ? 496
======================================
Hits ? 1916
Misses ? 584
Partials ? 116
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also update the patch version of the namespace, i.e., 2.0.x to 2.0.(x+1) since your are changing the schema.
In NeurodataWithoutBorders/nwb-schema#271 you should then also update the release of the nwb-schema docs.
Luckily, NWBDataInterface does not any fields so this change should not affect compatability.
Regarding updated author list, see also updates to nwb-schema: NeurodataWithoutBorders/nwb-schema#265 and NeurodataWithoutBorders/nwb-schema#266 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot #953 also changes the version, i.e., depending on the order these get merged we may need to update the version again.
Also t-b discovered in #953 another issue with the version in that we need to update the value of the nwb_version
attribute in nwb.file.yaml as well. While this is a separate issue that we should fix, we should in the meantime make sure to update both until we have fixed the problem with having nwb_version
as attribute in the schema.
Can we put all of these schema changes under 2.0.2 or should they be kept separate? |
Putting #953 and this PR under the 2.0.2 umbrella seems fine. #822 and #825 add new functionality and should be part of a separate version jump.
I remember we had some discussions about those PRs, which is why we did not merge those yet, but I don't recall what the issue was. @ajtritt do you recall if #822 and #825 were good to merge now? |
Fixes NeurodataWithoutBorders/nwb-schema#271 and improve documentation
Checklist
flake8
from the source directory.#XXX
notation whereXXX
is the issue number ?