-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read_nwb_method
for local paths in both hdf5 and zarr
#1994
base: dev
Are you sure you want to change the base?
Add read_nwb_method
for local paths in both hdf5 and zarr
#1994
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1994 +/- ##
==========================================
- Coverage 91.69% 91.39% -0.30%
==========================================
Files 27 27
Lines 2708 2719 +11
Branches 707 710 +3
==========================================
+ Hits 2483 2485 +2
- Misses 149 158 +9
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @h-mayorquin! Added my review comments
Is the sphinx links fail related to this PR? Given my experience with neuroconv is seldom is and I looked at the CI log but no luck. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! Added a few more small suggestions related to the docstrings.
f"Unable to read file: '{path}'. The file exists but is not recognized as " | ||
"either a valid HDF5 or Zarr NWB file. Please ensure the file contains valid NWB data." | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f"Unable to read file: '{path}'. The file exists but is not recognized as " | |
"either a valid HDF5 or Zarr NWB file. Please ensure the file contains valid NWB data." | |
) | |
f"Unable to read file: '{path}'. The file is not recognized as " | |
"either a valid HDF5 or Zarr NWB file. Please ensure the file exists and contains valid NWB data." | |
) |
I think this error will occur even if the file does not exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to modify the test though, so I am doing this into another commit.
Co-authored-by: Steph Prince <[email protected]>
Motivation
See #1974
How to test the behavior?
I added tests.
Checklist
ruff check . && codespell
from the source directory.